Unset \gre@ifbeginningofscore in \GreBarSyllables#1741
Open
davidweichiang wants to merge 6 commits intogregorio-project:developfrom
Open
Unset \gre@ifbeginningofscore in \GreBarSyllables#1741davidweichiang wants to merge 6 commits intogregorio-project:developfrom
davidweichiang wants to merge 6 commits intogregorio-project:developfrom
Conversation
Previously, beginningofscore would remain set if the first syllables were \GreBarSyllables. This would cause the first \GreSyllable to be set as if it were the first syllable of the line (with bolshift). Now, the first \GreSyllable should be set correctly.
davidweichiang
added a commit
to davidweichiang/gregorio-test
that referenced
this pull request
Apr 6, 2026
Contributor
Author
|
This changes a few tests, but the one that seems iffy to me is tex-output/fancyhdr-hooks/gregoriotest.tex. This one starts with a no-note syllable, which now has the effect of cancelling out the bolshift of the second syllable. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, beginningofscore would remain set if the first syllables were \GreBarSyllables. This would cause the first \GreSyllable to be set as if it were the first syllable of the line (with bolshift). Now, the first \GreSyllable should be set correctly.